Repository navigation
CI: run compiler tests on Windows - #984
Merged
Merged
Conversation
dcodeIO
reviewed
Dec 1, 2019
Member
|
LGTM, great to have this in CI. Just a minor comment above. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests the compiler on Windows as a separate CI job. This is designed to catch "bash-isms" that could otherwise sneak in, rather than provide full Windows coverage. Thus it only tests the stable node version.
On Linux, nvm is used to determine the current stable version. Since that does not work on Windows, the job uses nvm-windows as a substitute. That project is written in Golang, so a pre-compiled binary is downloaded and invoked directly.